[lkml]   [2009]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] tracing/markers: make markers select tracepoints

(cc to Frank and Mathieu)

> > > config MARKERS
> > > bool "Activate markers"
> > > - depends on TRACEPOINTS
> > > + select TRACEPOINTS
> > > help
> > > Place an empty function call at each marker site. Can be
> > > dynamically changed for a probe function.
> >
> > but using "select" instead of "depends on" just causes the
> > kind of problem that you described, whereas using "depends on"
> > does follow dependency chains.
> Well, as long as the secondary selects are 'expanded' along the
> line of dependencies, it should still be fine. With an
> increasing number of dependencies it quickly becomes ugly
> though. This might be one of the cases where it works.
> Eventually we should eliminate markers, their uses can either be
> converted to new-style tracepoints, or to ftrace_printk().

IIRC, this suggestion still don't get agreement of all tracing feature stakeholder.
We need to definitely discuss more lot and deep.
so I wonder why don't we create linux-tracing new mailing list.

tracer feature perfectly have new ML creation condition
- very active development
- many stakeholder and developer
- use many common parts (eg, marker, kprobe, unified buffer)

 \ /
  Last update: 2009-02-22 04:27    [W:0.203 / U:2.540 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site