lkml.org 
[lkml]   [2009]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: enable x2apic early at the first point

* Ingo Molnar <mingo@elte.hu> wrote:

> > arch/x86/kernel/apic/apic.c | 3 +--
> > arch/x86/kernel/apic/x2apic_cluster.c | 5 ++++-
> > arch/x86/kernel/apic/x2apic_phys.c | 5 ++++-
> > arch/x86/kernel/apic/x2apic_uv_x.c | 4 +++-
> > drivers/pci/dmar.c | 3 ++-
> > 5 files changed, 14 insertions(+), 6 deletions(-)
>
> I've applied it because it fixes a real bug, but this code
> really needs a cleanup. Look at the repeat patterns:

unapplied it again as it breaks the build:

arch/x86/kernel/apic/x2apic_cluster.c: In function 'x2apic_acpi_madt_oem_check':
arch/x86/kernel/apic/x2apic_cluster.c:17: error: 'disable_x2apic' undeclared (first use in this function)
arch/x86/kernel/apic/x2apic_cluster.c:17: error: (Each undeclared identifier is reported only once
arch/x86/kernel/apic/x2apic_cluster.c:17: error: for each function it appears in.)

so please resend the fixed and cleaned up version.

Thanks,

Ingo


\
 
 \ /
  Last update: 2009-02-20 10:59    [W:0.073 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site