Messages in this thread | | | Date | Fri, 20 Feb 2009 14:54:12 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] input: keyboard: introduce lm8323 driver |
| |
On Sat, 21 Feb 2009 00:29:12 +0200 Felipe Balbi <me@felipebalbi.com> wrote:
> On Fri, Feb 20, 2009 at 02:15:05PM -0800, Andrew Morton wrote: > > On Thu, 19 Feb 2009 14:31:17 +0200 > > Felipe Balbi <me@felipebalbi.com> wrote: > > > > > +struct lm8323_platform_data { > > > + int debounce_time; /* Time to watch for key bouncing, in ms. */ > > > + int active_time; /* Idle time until sleep, in ms. */ > > > + > > > + int size_x; > > > + int size_y; > > > + int repeat : 1; > > > > lm8323_platform_data.repeat appears to be never-written-to? > > Nobody is using that yet, still it's used in the driver: > if (pdata->repeat) > __set_bit(EV_REP, idev->evbit);
Yes, but that's presently dead code.
> Also, those spaces around : should vanish. Want me to resend the whole > patch or just a patch on top of it ?
I already fixed that.
| |