lkml.org 
[lkml]   [2009]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] PCI: Enable PCIe AER only after checking firmware support
On Thu, 19 Feb 2009 10:11:07 -0700
Andrew Patterson <andrew.patterson@hp.com> wrote:

> PCI: Enable PCIe AER only after checking firmware support
>
> The PCIe port driver currently sets the PCIe AER error reporting bits for
> any root or switch port without first checking to see if firmware will grant
> control. This patch moves setting these bits to the AER service driver
> aer_enable_port routine. The bits are then set for the root port and any
> downstream switch ports after the check for firmware support (aer_osc_setup)
> is made. The patch also unsets the bits in a similar fashion when the AER
> service driver is unloaded.
>
> ...
>
> +/**
> + * set_downstream_devices_error_reporting - enable/disable the error reporting
> + * bits on the root port and its downstream ports.

Alas, silly kerneldoc does not permit multi-line titles. We're forced
to do this:

--- a/drivers/pci/pcie/aer/aerdrv_core.c~pci-enable-pcie-aer-only-after-checking-firmware-support-fix
+++ a/drivers/pci/pcie/aer/aerdrv_core.c
@@ -125,8 +125,7 @@ static void set_device_error_reporting(s
}

/**
- * set_downstream_devices_error_reporting - enable/disable the error reporting
- * bits on the root port and its downstream ports.
+ * set_downstream_devices_error_reporting - enable/disable the error reporting bits on the root port and its downstream ports.
* @dev: pointer to root port's pci_dev data structure
* @enable: true = enable error reporting, false = disable error reporting.
*/
_


\
 
 \ /
  Last update: 2009-02-20 22:55    [W:0.038 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site