Messages in this thread | | | Date | Fri, 20 Feb 2009 08:28:42 -0700 | Subject | Re: [PATCH] Export device_add_attributes() so drivers can use it. | From | Grant Likely <> |
| |
Hi Kay,
Thanks for the reply, it clarifies a lot. It sounds like this really should be documented (in Documentation/driver-model/device.txt?). I'm happy to add a blurb to that effect and send a patch, but I want to make sure I really understand the model before I do so. I've got a couple more questions below:
On Thu, Feb 19, 2009 at 4:08 PM, Kay Sievers <kay.sievers@vrfy.org> wrote: [...] > If an attribute is not available at event time, nothing of this can > ever work. If you look a the device a second later, you will see the > proper looking files and values, and all the test programs will work, > but it will always fail at device creation. [...] > That all might not be needed for your specific setup/driver/device and > may work fine for your need. But we don't want to encourage anybody > with another new API which creates the usual trouble we need to fix > later.
Fair enough
> And we need to fix things like this all the time.
Can you point me at a 'textbook' example of one of these fixups?
> Also the existing sysfs attribute groups API has the same problem if > the group is created later, but as far as I can see it should work > fine for your purpose. So it's better using that, instead of exporting > another different API.
Okay, I this option looks pretty straight forward too.
Thanks, g.
-- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.
| |