lkml.org 
[lkml]   [2009]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [-mm patch] Show memcg information during OOM
On Tue, 3 Feb 2009, Balbir Singh wrote:

> > > diff --git a/mm/oom_kill.c b/mm/oom_kill.c
> > > index d3b9bac..b8e53ae 100644
> > > --- a/mm/oom_kill.c
> > > +++ b/mm/oom_kill.c
> > > @@ -392,6 +392,7 @@ static int oom_kill_process(struct task_struct *p, gfp_t gfp_mask, int order,
> > > current->comm, gfp_mask, order, current->oomkilladj);
> > > task_lock(current);
> > > cpuset_print_task_mems_allowed(current);
> > > + mem_cgroup_print_mem_info(mem);
> >
> > I think this can be put outside the task lock. The lock is used to call task_cs() safely in
> > cpuset_print_task_mems_allowed().
> >
>
> Thanks, I'll work on that in the next version.
>

I was also wondering about this and assumed that it was necessary to
prevent the cgroup from disappearing during the oom. If task_lock() isn't
held, is the memcg->css.cgroup->dentry->d_name.name dereference always
safe without rcu?


\
 
 \ /
  Last update: 2009-02-03 05:49    [W:0.090 / U:0.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site