lkml.org 
[lkml]   [2009]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: PCI PM: Restore standard config registers of all devices early
    From
    Date
    On Tue, 2009-02-03 at 12:46 +1100, Benjamin Herrenschmidt wrote:
    > > Note how the PCI layer (currently) only saves the low _16_ dwords of
    > > config space (64 bytes). The radeonfb code that did it by hand saved the
    > > whole 64 dwords (256 bytes). It _probably_ doesn't matter, but..
    > >
    > > The reason the PCI layer only does 64 bytes is that that was the really
    > > old PCI config space model - the rest was undefined and apparently a few
    > > cards reportedly even crashed when accessing it (but who knows, that may
    > > be urban folklore).
    > >
    > > But if that patch works for you, it's clearly already better than _not_
    > > applying the patch, so..
    >
    > Radeons don't do much with config space... the worst we may miss I
    > suppose is subsystem vendor/device... Maybe I'll add something to
    > explicitely save and restore it or X might get upset. I'll have a look.

    Actually, subsystem stuff is below 0x40 so it should be fine too.

    Cheers,
    Ben.




    \
     
     \ /
      Last update: 2009-02-03 04:33    [W:4.074 / U:0.292 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site