lkml.org 
[lkml]   [2009]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] Add enable_ms to jsm driver
On Fri, 30 Jan 2009 10:21:49 -0600
Paul Larson <pl@linux.vnet.ibm.com> wrote:

>
> This fixes a crash observed when non-existant enable_ms function is
> called for jsm driver.
>
> Signed-off-by: Scott Kilau <Scott.Kilau@digi.com>
> Signed-off-by: Paul Larson <pl@linux.vnet.ibm.com>
> ---
> drivers/serial/jsm/jsm_tty.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/serial/jsm/jsm_tty.c b/drivers/serial/jsm/jsm_tty.c
> index 3547558..324c74d 100644
> --- a/drivers/serial/jsm/jsm_tty.c
> +++ b/drivers/serial/jsm/jsm_tty.c
> @@ -161,6 +161,11 @@ static void jsm_tty_stop_rx(struct uart_port *port)
> channel->ch_bd->bd_ops->disable_receiver(channel);
> }
>
> +static void jsm_tty_enable_ms(struct uart_port *port)
> +{
> + /* Nothing needed */
> +}
> +
> static void jsm_tty_break(struct uart_port *port, int break_state)
> {
> unsigned long lock_flags;
> @@ -345,6 +350,7 @@ static struct uart_ops jsm_ops = {
> .start_tx = jsm_tty_start_tx,
> .send_xchar = jsm_tty_send_xchar,
> .stop_rx = jsm_tty_stop_rx,
> + .enable_ms = jsm_tty_enable_ms,
> .break_ctl = jsm_tty_break,
> .startup = jsm_tty_open,
> .shutdown = jsm_tty_close,

This patch is now in mainline for 2.6.29, as
0461ec5bc7745b89a8ab67ba0ea497abd58a6301.

It appears to be needed in every 2.6.x kernel back to at least 2.6.25,
but nobody told the -stable maintainers about this.

An appropriate way of flagging this is to add

Cc: <stable@kernel.org>

to the changelog body.


\
 
 \ /
  Last update: 2009-02-03 00:47    [W:0.718 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site