Messages in this thread | | | Date | Mon, 2 Feb 2009 01:09:14 -0700 (MST) | From | Paul Walmsley <> | Subject | Re: [PATCH F 12/12] OMAP2/3 McBSP: add temporary clockdomain fix for McBSP virtual clocks |
| |
Hi Russell,
On Sat, 31 Jan 2009, Russell King - ARM Linux wrote:
> On Wed, Jan 28, 2009 at 12:35:33PM -0700, Paul Walmsley wrote: > > The McBSP driver uses virtual clocks to handle enabling and disabling > > its hardware clocks. These virtual clocks have no associated > > clockdomain. After commit 60b8b431e47d8c5b8c02a2e4fa9af388aae20790, > > this prevents the McBSP clocks from registering correctly. > > Resolve this for the short term by using virt_opp_clkdm for these clocks. > > These McBSP virtual clocks should be removed, but such a fix would require > > significant changes to the McBSP drivers that would require testing on > > OMAP1, 2, and 3 platforms. > > With either my clkdev patches or the spinlock fixing for mcbsp, this patch > seems to be redundant.
Indeed. It was included so the patch set would work if your tree didn't have Stanley's McBSP patch applied; I don't think it's made it up to mainline.
- Paul
| |