lkml.org 
[lkml]   [2009]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] sx.c: fix dbl statement if - add missing braces
From
On 2/18/09, Ilpo Järvinen <ilpo.jarvinen@helsinki.fi> wrote:
>
> Caused by 736d54533aed (sx.c: fix missed unlock_kernel()
> on error path in sx_fw_ioctl()). You guys keep breaking
> things this way in every single kernel release in at least
> couple of places... :-(
>

Yep. Sorry about that.

Signed-off-by: Dan Carpenter <error27@gmail.com>

regards,
dan carpenter

> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
> Cc: Dan Carpenter <error27@gmail.com>
> ---
> drivers/char/sx.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/char/sx.c b/drivers/char/sx.c
> index f146e90..d7c4165 100644
> --- a/drivers/char/sx.c
> +++ b/drivers/char/sx.c
> @@ -1746,9 +1746,10 @@ static long sx_fw_ioctl(struct file *filp, unsigned
> int cmd,
> sx_dprintk(SX_DEBUG_FIRMWARE, "returning type= %ld\n", rc);
> break;
> case SXIO_DO_RAMTEST:
> - if (sx_initialized) /* Already initialized: better not ramtest the board.
> */
> + if (sx_initialized) { /* Already initialized: better not ramtest the
> board. */
> rc = -EPERM;
> break;
> + }
> if (IS_SX_BOARD(board)) {
> rc = do_memtest(board, 0, 0x7000);
> if (!rc)
> --
> 1.5.2.2
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-02-19 11:05    [W:0.051 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site