Messages in this thread | | | From | Roland McGrath <> | Subject | Re: [PATCH 2/4] forget_original_parent: do not abuse child->ptrace_entry | Date | Thu, 19 Feb 2009 18:28:23 -0800 (PST) |
| |
> - rename ptrace_dead to dead_childs.
s/dead_childs/dead_children/
> Actually, I don't understand why do we notify /sbin/init when we > reparent a zombie, probably it is better to reap it unconditionally.
It is traditional behavior. It gives the init implementation the option to report/log/analyze the details of abandoned zombies. (Whether or not that really seems useful, there is no good reason to restrict the possibility.)
> +/* > +* Any that need to be release_task'd are put on the @dead list. > + */
Missing leading space on the second comment lien.
Modulo those cosmetic things, ACK on this.
Thanks, Roland
| |