Messages in this thread | | | Date | Thu, 19 Feb 2009 16:54:29 -0800 (PST) | From | Sitsofe Wheeler <> | Subject | Re: [SCSI][REGRESSION][BISECTED] Disk errors loop forever in 2.6.29 |
| |
> From: James Bottomley <James.Bottomley@HansenPartnership.com>
> > Your specific behaviour change seems to be a bug in the way the rewrite > is handling ABORTED_COMMAND. Could you try the patch below (with or > without the block patch, it shouldn't matter) and see if it gets you > back to 2.6.28 behaviour?
Yup that patch makes things timeout quickly just like 2.6.28. The whole "it didn't used to cache failures" piece in the previous email seems to have been a fabrication inside my own head - I checked and 2.6.28 caches the failure until the cache is dropped too.
It might be worth turning your original patch into some sort of warning stack trace trigger so that people understand it's just there for unwedging and isn't expected behaviour (it is useful for breaking out of near lockups though).
Tested-by: Sitsofe Wheeler <sitsofe@yahoo.com>
| |