lkml.org 
[lkml]   [2009]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: remove unneeded endless loop in BUG()
Jeremy Fitzhardinge wrote:
>
> There's no reason to expect an "asm volatile" to stay put; the
> "volatile" has nothing to do with preventing code motion. The only way
> to make an asm stick in one place is with data dependencies, and I'm not
> sure what the dependency for __builtin_trap might be. I'm guessing its
> a "memory" clobber, but that's pure guesswork.
>

I looked through this with HJL; the bottom line is that although it
probably would work, it's not worth it.

I submitted GCC bug 39252 to get __builtin_not_reached(); instead.

-hpa


\
 
 \ /
  Last update: 2009-02-19 21:55    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog