Messages in this thread | | | Date | Wed, 18 Feb 2009 17:49:58 -0800 (PST) | Subject | Re: [PATCH] drivers/net/sfc: fix sparse warnings: Should it be static? | From | David Miller <> |
| |
From: Hannes Eder <hannes@hanneseder.net> Date: Mon, 16 Feb 2009 10:54:38 +0100
> Impact: Include the header file. If CONFIG_SFC_MTD is not defined > then the functions 'efx_mtd_remove' and 'efx_mtd_rename' are defined > 'static inline' with an empty function body in the header file, but > the the whole file mtd.c is not built in this case. > > Fix this sparse warnings: > drivers/net/sfc/mtd.c:204:6: warning: symbol 'efx_mtd_remove' was not declared. Should it be static? > drivers/net/sfc/mtd.c:221:6: warning: symbol 'efx_mtd_rename' was not declared. Should it be static? > drivers/net/sfc/mtd.c:230:5: warning: symbol 'efx_mtd_probe' was not declared. Should it be static? > > Signed-off-by: Hannes Eder <hannes@hanneseder.net>
Applied to net-next-2.6, thanks.
| |