lkml.org 
[lkml]   [2009]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [locking bug] inotify: inconsistent {RECLAIM_FS-ON-W} -> {IN-RECLAIM_FS-W} usage.
On Mon, 16 Feb 2009 09:13:04 +0100
Ingo Molnar <mingo@elte.hu> wrote:

> --- a/fs/notify/inotify/inotify.c
> +++ b/fs/notify/inotify/inotify.c
> @@ -156,7 +156,7 @@ static int inotify_handle_get_wd(struct inotify_handle *ih,
> int ret;
>
> do {
> - if (unlikely(!idr_pre_get(&ih->idr, GFP_KERNEL)))
> + if (unlikely(!idr_pre_get(&ih->idr, GFP_NOFS)))

Geeze the IDR interface sucks.

> return -ENOSPC;

Well that doesn't make a lot of sense.

> ret = idr_get_new_above(&ih->idr, watch, ih->last_wd+1, &watch->wd);
> } while (ret == -EAGAIN);

And afacit that can't happen. We hold the lock, so if idr_pre_get()
succeeded, idr_get_new_above() will not return -EAGAIN (which should
have been -ENOMEM).

I'd better stop looking.



\
 
 \ /
  Last update: 2009-02-18 23:29    [W:0.045 / U:0.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site