lkml.org 
[lkml]   [2009]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -mmotm] asiliantfb: fix ISO declaration/code warning
On Wed, 18 Feb 2009 11:12:54 -0800
Randy Dunlap <randy.dunlap@oracle.com> wrote:

> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Move data declaration before any code:
>
> drivers/video/asiliantfb.c:515: warning: ISO C90 forbids mixed
> declarations and code
>
> (from asiliantfb-fix-cmap-memory-leaks.patch)
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>


Looks obviously correct to me.

Acked-by: Andres Salomon <dilinger@debian.org>


> ---
> drivers/video/asiliantfb.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- mmotm-2009-0218-0215.orig/drivers/video/asiliantfb.c
> +++ mmotm-2009-0218-0215/drivers/video/asiliantfb.c
> @@ -507,12 +507,13 @@ static struct fb_var_screeninfo asiliant
>
> static int __devinit init_asiliant(struct fb_info *p, unsigned long
> addr) {
> + int err;
> +
> p->fix = asiliantfb_fix;
> p->fix.smem_start = addr;
> p->var = asiliantfb_var;
> p->fbops = &asiliantfb_ops;
> p->flags = FBINFO_DEFAULT;
> - int err;
>
> err = fb_alloc_cmap(&p->cmap, 256, 0);
> if (err) {
>


\
 
 \ /
  Last update: 2009-02-18 20:37    [W:0.037 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site