Messages in this thread | | | Date | Wed, 18 Feb 2009 14:34:44 -0500 | From | Andres Salomon <> | Subject | Re: [PATCH -mmotm] asiliantfb: fix ISO declaration/code warning |
| |
On Wed, 18 Feb 2009 11:12:54 -0800 Randy Dunlap <randy.dunlap@oracle.com> wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com> > > Move data declaration before any code: > > drivers/video/asiliantfb.c:515: warning: ISO C90 forbids mixed > declarations and code > > (from asiliantfb-fix-cmap-memory-leaks.patch) > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Looks obviously correct to me.
Acked-by: Andres Salomon <dilinger@debian.org>
> --- > drivers/video/asiliantfb.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > --- mmotm-2009-0218-0215.orig/drivers/video/asiliantfb.c > +++ mmotm-2009-0218-0215/drivers/video/asiliantfb.c > @@ -507,12 +507,13 @@ static struct fb_var_screeninfo asiliant > > static int __devinit init_asiliant(struct fb_info *p, unsigned long > addr) { > + int err; > + > p->fix = asiliantfb_fix; > p->fix.smem_start = addr; > p->var = asiliantfb_var; > p->fbops = &asiliantfb_ops; > p->flags = FBINFO_DEFAULT; > - int err; > > err = fb_alloc_cmap(&p->cmap, 256, 0); > if (err) { >
| |