[lkml]   [2009]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] SMACK netfilter smacklabel socket match
    On Wednesday 18 February 2009 01:29:11 pm etienne wrote:
    > OK, I'm about to send a new patch; but while testing my patches and reading
    > code, I noticed another bug :
    > In smackfs.c:smk_write_netlbladdr
    > the netmask mask.s_addr is not handled correctly, the netmask should be :
    > 1- computed in u32
    > 2- converted to be32 !!
    > with current code, a "pseudo u32 mask" is applied to a be32 ipaddr; it
    > occurs to works for "common netmasks" (multiple of 8), not for
    > "intermediate" mask (/15, /25)

    Heh, back when Casey was first drafting this code I mentioned the same issue
    regarding byte ordering but Casey assured me that everything was correct. I
    didn't have a Smack test system at the time so I couldn't verify the behavior.
    I'm glad you had a chance to test it, needless to say you should fix that when
    you submit your patch.

    paul moore
    linux @ hp

     \ /
      Last update: 2009-02-18 20:23    [W:0.022 / U:20.092 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site