lkml.org 
[lkml]   [2009]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cpufreq: Change link order of x86 cpufreq modules
On Wed, Feb 18, 2009 at 07:31:37PM +0100, Ingo Molnar wrote:
>
> * Matthew Garrett <mjg59@srcf.ucam.org> wrote:
>
> > Change the link order of the cpufreq modules to ensure that they're
> > probed in the preferred order when statically linked in.
> >
> > Signed-off-by: Matthew Garrett <mjg@redhat.com>
> >
> > diff --git a/arch/x86/kernel/cpu/cpufreq/Makefile b/arch/x86/kernel/cpu/cpufreq/Makefile
> > index 560f776..509296d 100644
> > --- a/arch/x86/kernel/cpu/cpufreq/Makefile
> > +++ b/arch/x86/kernel/cpu/cpufreq/Makefile
> > @@ -1,6 +1,11 @@
> > +# Link order matters. K8 is preferred to ACPI because of firmware bugs in early
> > +# K8 systems. ACPI is preferred to all other hardware-specific drivers.
> > +# speedstep-* is preferred over p4-clockmod.
>
> Nice fix! Where does this information come from? Distro module
> ordering magic? It's rather non-trivial.

it's a mess of shell script right now.
See /etc/init.d/cpuspeed on Fedora for eg.

> (small style nit: the first line in the Makefile is overlong.)

I'll fix that up before merging.

Thanks Matthew, queued for .30

Dave


--
http://www.codemonkey.org.uk


\
 
 \ /
  Last update: 2009-02-18 19:37    [W:0.103 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site