lkml.org 
[lkml]   [2009]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Suspend and Resume Support for Intel IOMMU


On Wed, 18 Feb 2009, Fenghua Yu wrote:
>
> +static int vtd_enabled;
..
> +static int iommu_resume(struct sys_device *dev)
> +{
..
> + if (!vtd_enabled)
> + return 0;

Hmm. Why do this?

Wouldn't it be much more logical to only register the iommu_sysdev if the
thing is enabled, rather than having an odd flag that gets tested at
runtime?

Linus


\
 
 \ /
  Last update: 2009-02-18 18:15    [W:0.585 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site