Messages in this thread | | | Date | Tue, 17 Feb 2009 10:39:54 -0800 | From | Greg KH <> | Subject | Re: [PATCH] input: xpad.c - Xbox 360 wireless and sysfs support |
| |
On Tue, Feb 17, 2009 at 01:27:48PM -0500, Mike Murphy wrote: > On Mon, Feb 16, 2009 at 11:57 PM, Mike Murphy <mamurph@cs.clemson.edu> wrote: > > Unless that is some common error that is obvious from its description, > > I will have to chase the bug down tomorrow or Wednesday. It's getting > > a bit late here. > > > > Fixed... the function signature was wrong. Should have been:
Ah, always pay attention to complier warnings :)
> static ssize_t xpad_show_dead_zone(struct device *dev, struct > device_attribute *attr, char *buf) > > Incidentally, both Documentation/driver-model/device.txt and > Documentation/filesystems/sysfs.txt appear to be wrong. The former > defines the device attribute structure as:
<snip>
Care to send a patch to fix up the documentation?
thanks,
greg k-h
| |