lkml.org 
[lkml]   [2009]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] niu: improve ethtool support for gigabit copper cards
Ben Hutchings <bhutchings@solarflare.com> wrote:
> On Tue, 2009-02-17 at 15:43 +0400, Constantin Baranov wrote:
> > Introduced support for link speed and duplex setting (ethtool -s),
> > link advertising parameters and autonegotiation (ethtool -r):
> [...]
>
> I haven't looked closely at this, but is there anything here that can't
> be handled by mii_get_settings() and other functions in the mii driver?

mii_ethtool_gset() reports fixed set of supported modes and mii_ethtool_sset()
doesn't check whether requested mode is supported when autonegotiation is
disabled. Also mii module declares mdio_write() operation as returning void,
thus mii routines will ignore errors that may occur. Although all of these is
not so critical I decided not to use mii module.

--
Constantin Baranov,
Mercury Development, LLC


\
 
 \ /
  Last update: 2009-02-18 12:23    [W:0.801 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site