Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH 3/4] generic-smp: properly allocate the cpumasks | Date | Tue, 17 Feb 2009 09:47:05 +1030 |
| |
On Tuesday 17 February 2009 03:08:50 Peter Zijlstra wrote: > Its not deemed proper to have full cpumasks in data anymore, we have to > dynamically allocate them based on runtime determined dimensions of the > machine in question.
Wow, thanks.
But FYI I would have been happy with allocating them for each possible CPU, rather than doing the hotplug callback thing.
If you really *can* have 4096 CPUS, I'm not so upset about spending 2M; it's when you've got 2 CPUs and the distro has set CONFIG_NR_CPUS=4096 that I care about.
I'm not saying to fix it, I'm just saying you went beyond the call of duty.
Kudos, Rusty.
| |