lkml.org 
[lkml]   [2009]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [Patch] list usage cleanup in MISDN
Date: Fri, 13 Feb 2009 09:10:57 +0100

Trivial cleanup, list_del(); list_add_tail() is equivalent
to list_move_tail(). Semantic patch for coccinelle can be
found at www.cccmz.de/~snakebyte/list_move_tail.spatch

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Acked-by: Karsten Keil <kkeil@novell.com>

diff -u -p a/drivers/isdn/mISDN/timerdev.c b/drivers/isdn/mISDN/timerdev.c
--- a/drivers/isdn/mISDN/timerdev.c 2008-12-29 01:36:06.000000000 +0100
+++ b/drivers/isdn/mISDN/timerdev.c 2009-02-11 15:44:06.000000000 +0100
@@ -152,8 +152,7 @@ dev_expire_timer(unsigned long data)
u_long flags;

spin_lock_irqsave(&timer->dev->lock, flags);
- list_del(&timer->list);
- list_add_tail(&timer->list, &timer->dev->expired);
+ list_move_tail(&timer->list, &timer->dev->expired);
spin_unlock_irqrestore(&timer->dev->lock, flags);
wake_up_interruptible(&timer->dev->wait);
}
--
Karsten Keil
SuSE Labs
ISDN and VOIP development
SUSE LINUX Products GmbH, Maxfeldstr.5 90409 Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg)


\
 
 \ /
  Last update: 2009-02-18 12:23    [W:0.040 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site