Messages in this thread | | | Date | Mon, 16 Feb 2009 21:06:51 +0100 | From | Sam Ravnborg <> | Subject | Re: [PATCH] Replace deprecated __initcall with device_initcall and fix whitespaces in kernel/kallsyms.c |
| |
On Mon, Feb 16, 2009 at 09:54:25PM +0530, Manish Katiyar wrote: > Patch to fix coding style whitespace issues and replace __initcall > with device_initcall > > Errors as reported by checkpatch.pl :- > Before: > total: 14 errors, 14 warnings, 487 lines checked > After : > total: 0 errors, 11 warnings, 486 lines checked > > Compile tested binary verified as :- > Before: > text data bss dec hex filename > 2405 4 0 2409 969 kernel/kallsyms.o > After : > text data bss dec hex filename > 2405 4 0 2409 969 kernel/kallsyms.o > > > Signed-off-by: Manish Katiyar <mkatiyar@gmail.com>
You did not fix the "spaces around operators" issue I showed you. And you have not done an intellegent conding-style cleanup as described in another mail by Ingo(*).
(*) As your changelog does not say so I assume you did no do it.
So please try again and be more critical this time and try to address the issues raised.
Thanks, Sam
| |