lkml.org 
[lkml]   [2009]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [patch 6/8] cifs: use kzfree()
From
Hi Johannes,

On Mon, Feb 16, 2009 at 4:29 PM, Johannes Weiner <hannes@cmpxchg.org> wrote:
> @@ -2433,11 +2433,8 @@ mount_fail_check:
> out:
> /* zero out password before freeing */
> if (volume_info) {
> - if (volume_info->password != NULL) {
> - memset(volume_info->password, 0,
> - strlen(volume_info->password));
> - kfree(volume_info->password);
> - }
> + if (volume_info->password != NULL)
> + kzfree(volume_info->password);

The NULL check here is unnecessary.

> kfree(volume_info->UNC);
> kfree(volume_info->prepath);
> kfree(volume_info);
> --- a/fs/cifs/misc.c
> +++ b/fs/cifs/misc.c
> @@ -97,10 +97,8 @@ sesInfoFree(struct cifsSesInfo *buf_to_f
> kfree(buf_to_free->serverOS);
> kfree(buf_to_free->serverDomain);
> kfree(buf_to_free->serverNOS);
> - if (buf_to_free->password) {
> - memset(buf_to_free->password, 0, strlen(buf_to_free->password));
> - kfree(buf_to_free->password);
> - }
> + if (buf_to_free->password)
> + kzfree(buf_to_free->password);

And here.

> kfree(buf_to_free->domainName);
> kfree(buf_to_free);
> }
> @@ -132,10 +130,8 @@ tconInfoFree(struct cifsTconInfo *buf_to
> }
> atomic_dec(&tconInfoAllocCount);
> kfree(buf_to_free->nativeFileSystem);
> - if (buf_to_free->password) {
> - memset(buf_to_free->password, 0, strlen(buf_to_free->password));
> - kfree(buf_to_free->password);
> - }
> + if (buf_to_free->password)
> + kzfree(buf_to_free->password);
> kfree(buf_to_free);
> }
>
>
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>


\
 
 \ /
  Last update: 2009-02-18 12:23    [from the cache]
©2003-2011 Jasper Spaans