Messages in this thread | | | Date | Mon, 16 Feb 2009 15:00:31 +0100 | From | Stefan Richter <> | Subject | Re: [PATCH] Remove errors caught by checkpatch.pl in kernel/kallsyms.c |
| |
Ingo Molnar wrote: > * Stefan Richter <stefanr@s5r6.in-berlin.de> wrote: >> Furthermore, the changelog is bad (non-exiting in fact). >> >> The fact that the issues where discovered using checkpatch is absolutely >> uninteresting. The changelog should describe /what/ is fixed, [...] > > The commit log definitely needs enhancements but it's not uninteresting > at all what tools were used to arrive to a change. [...] if a > good and acceptable commit results out of a tool's usage then that tool > needs to be advertised some more.)
Fine, then the author could mention it below the --- delimitor in the patch posting. The changelog however, as annotation of the source history, is not a billboard. We also don't describe for example that a nice cup of hot Earl Grey or whatever was vital to the creation of a patch. -- Stefan Richter -=====-==--= --=- =---- http://arcgraph.de/sr/
| |