lkml.org 
[lkml]   [2009]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] x86: pre init pirq_entries[]

    Impact: cleanup

    set default value early. also could remove pirqs_enabled...
    and one #ifdef

    Signed-off-by: Yinghai Lu <yinghai@kernel.org>

    ---
    arch/x86/kernel/io_apic.c | 16 +++-------------
    1 file changed, 3 insertions(+), 13 deletions(-)

    Index: linux-2.6/arch/x86/kernel/io_apic.c
    ===================================================================
    --- linux-2.6.orig/arch/x86/kernel/io_apic.c
    +++ linux-2.6/arch/x86/kernel/io_apic.c
    @@ -813,8 +813,9 @@ static void clear_IO_APIC (void)
    */

    #define MAX_PIRQS 8
    -static int pirq_entries [MAX_PIRQS];
    -static int pirqs_enabled;
    +static int pirq_entries[MAX_PIRQS] = {
    + [0 ... MAX_PIRQS - 1] = -1
    +};

    static int __init ioapic_pirq_setup(char *str)
    {
    @@ -823,10 +824,6 @@ static int __init ioapic_pirq_setup(char

    get_options(str, ARRAY_SIZE(ints), ints);

    - for (i = 0; i < MAX_PIRQS; i++)
    - pirq_entries[i] = -1;
    -
    - pirqs_enabled = 1;
    apic_printk(APIC_VERBOSE, KERN_INFO
    "PIRQ redirection, working around broken MP-BIOS.\n");
    max = MAX_PIRQS;
    @@ -1976,13 +1973,6 @@ void __init enable_IO_APIC(void)
    int apic;
    unsigned long flags;

    -#ifdef CONFIG_X86_32
    - int i;
    - if (!pirqs_enabled)
    - for (i = 0; i < MAX_PIRQS; i++)
    - pirq_entries[i] = -1;
    -#endif
    -
    /*
    * The number of IO-APIC IRQ registers (== #pins):
    */

    \
     
     \ /
      Last update: 2009-02-15 11:57    [W:0.025 / U:29.428 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site