lkml.org 
[lkml]   [2009]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: hp accelerometer: add freefall detection
Date
Hi Pavel,

> +++ b/drivers/hwmon/lis3lv02d.c
[...]
> +static int lis3lv02d_misc_open(struct inode *inode, struct file *file)
[...]
> + if (ret) {
> + clear_bit(0, &adev.misc_opened);
> + printk(KERN_ERR DRIVER_NAME ": IRQ%d allocation failed\n", ad
> + return -EBUSY;
> + }
> + lis3lv02d_increase_use(&adev);
> + printk("lis3: registered interrupt %d\n", adev.irq);

Is this a debug printk that should be removed altogether or should it
be given a proper format and KERN_DEBUG?

> + return 0;
> +}
[...]
> @@ -268,6 +393,19 @@ int lis3lv02d_init_device(struct acpi_lis3lv02d
> *dev) if (lis3lv02d_joystick_enable())
> printk(KERN_ERR DRIVER_NAME ": joystick initialization failed
>
> + printk("lis3_init_device: irq %d\n", dev->irq);

Same here.

> +
> + /* if we did not get an IRQ from ACPI - we have nothing more to do */
> + if (!dev->irq) {
> + printk(KERN_ERR DRIVER_NAME
> + ": No IRQ in ACPI. Disabling /dev/freefall\n");
> + goto out;
> + }
> +
> + printk("lis3: registering device\n");

And here.

> + if (misc_register(&lis3lv02d_misc_device))
> + printk(KERN_ERR DRIVER_NAME ": misc_register failed\n");

Cheers,
FJP


\
 
 \ /
  Last update: 2009-02-14 17:03    [W:0.067 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site