Messages in this thread | | | From | Frans Pop <> | Subject | Re: hp accelerometer: add freefall detection | Date | Sat, 14 Feb 2009 17:01:01 +0100 |
| |
Hi Pavel,
> +++ b/drivers/hwmon/lis3lv02d.c [...] > +static int lis3lv02d_misc_open(struct inode *inode, struct file *file) [...] > + if (ret) { > + clear_bit(0, &adev.misc_opened); > + printk(KERN_ERR DRIVER_NAME ": IRQ%d allocation failed\n", ad > + return -EBUSY; > + } > + lis3lv02d_increase_use(&adev); > + printk("lis3: registered interrupt %d\n", adev.irq);
Is this a debug printk that should be removed altogether or should it be given a proper format and KERN_DEBUG?
> + return 0; > +} [...] > @@ -268,6 +393,19 @@ int lis3lv02d_init_device(struct acpi_lis3lv02d > *dev) if (lis3lv02d_joystick_enable()) > printk(KERN_ERR DRIVER_NAME ": joystick initialization failed > > + printk("lis3_init_device: irq %d\n", dev->irq);
Same here.
> + > + /* if we did not get an IRQ from ACPI - we have nothing more to do */ > + if (!dev->irq) { > + printk(KERN_ERR DRIVER_NAME > + ": No IRQ in ACPI. Disabling /dev/freefall\n"); > + goto out; > + } > + > + printk("lis3: registering device\n");
And here.
> + if (misc_register(&lis3lv02d_misc_device)) > + printk(KERN_ERR DRIVER_NAME ": misc_register failed\n");
Cheers, FJP
| |