lkml.org 
[lkml]   [2009]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 36/43] drivers/net/wan: fix sparse warning: symbol shadows an earlier one
    Date
    Impact: Rename function scope variable and while being at it fix some
    coding style issues.

    Fix this sparse warning:
    drivers/net/wan/sbni.c:1526:14: warning: symbol 'num' shadows an earlier one
    drivers/net/wan/sbni.c:160:13: originally declared here

    Signed-off-by: Hannes Eder <hannes@hanneseder.net>
    ---
    drivers/net/wan/sbni.c | 17 +++++++++--------
    1 files changed, 9 insertions(+), 8 deletions(-)

    diff --git a/drivers/net/wan/sbni.c b/drivers/net/wan/sbni.c
    index 0aa28e1..78f7bc9 100644
    --- a/drivers/net/wan/sbni.c
    +++ b/drivers/net/wan/sbni.c
    @@ -1520,17 +1520,18 @@ int __init init_module( void )
    }

    void
    -cleanup_module( void )
    +cleanup_module(void)
    {
    - struct net_device *dev;
    - int num;
    + int i;

    - for( num = 0; num < SBNI_MAX_NUM_CARDS; ++num )
    - if( (dev = sbni_cards[ num ]) != NULL ) {
    - unregister_netdev( dev );
    - release_region( dev->base_addr, SBNI_IO_EXTENT );
    - free_netdev( dev );
    + for (i = 0; i < SBNI_MAX_NUM_CARDS; ++i) {
    + struct net_device *dev = sbni_cards[i];
    + if (dev != NULL) {
    + unregister_netdev(dev);
    + release_region(dev->base_addr, SBNI_IO_EXTENT);
    + free_netdev(dev);
    }
    + }
    }

    #else /* MODULE */


    \
     
     \ /
      Last update: 2009-02-14 22:53    [W:0.021 / U:91.668 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site