lkml.org 
[lkml]   [2009]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 06/43] drivers/net/lance.c: fix sparse warnings: fix signedness
    Date
    Impact: Besides from fixing the signedness issue remove some
    whitespace to obey to the 80 character limit.

    Fix this sparse warnings:
    drivers/net/lance.c:399:19: warning: incorrect type in assignment (different signedness)
    drivers/net/lance.c:654:29: warning: incorrect type in argument 2 (different signedness)

    Signed-off-by: Hannes Eder <hannes@hanneseder.net>
    ---
    drivers/net/lance.c | 11 ++++++-----
    1 files changed, 6 insertions(+), 5 deletions(-)

    diff --git a/drivers/net/lance.c b/drivers/net/lance.c
    index d7afb93..d83d401 100644
    --- a/drivers/net/lance.c
    +++ b/drivers/net/lance.c
    @@ -391,7 +391,8 @@ MODULE_LICENSE("GPL");
    */
    static int __init do_lance_probe(struct net_device *dev)
    {
    - int *port, result;
    + unsigned int *port;
    + int result;

    if (high_memory <= phys_to_virt(16*1024*1024))
    lance_need_isa_bounce_buffers = 0;
    @@ -456,13 +457,13 @@ out:
    static int __init lance_probe1(struct net_device *dev, int ioaddr, int irq, int options)
    {
    struct lance_private *lp;
    - long dma_channels; /* Mark spuriously-busy DMA channels */
    + unsigned long dma_channels; /* Mark spuriously-busy DMA channels */
    int i, reset_val, lance_version;
    const char *chipname;
    /* Flags for specific chips or boards. */
    - unsigned char hpJ2405A = 0; /* HP ISA adaptor */
    - int hp_builtin = 0; /* HP on-board ethernet. */
    - static int did_version; /* Already printed version info. */
    + unsigned char hpJ2405A = 0; /* HP ISA adaptor */
    + int hp_builtin = 0; /* HP on-board ethernet. */
    + static int did_version; /* Already printed version info. */
    unsigned long flags;
    int err = -ENOMEM;
    void __iomem *bios;


    \
     
     \ /
      Last update: 2009-02-14 22:17    [W:0.031 / U:0.112 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site