lkml.org 
[lkml]   [2009]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] clockevents: avoid unnecessary reprograming of event timer
On Fri, 13 Feb 2009, Ingo Molnar wrote:
> > + if (ktime_equal(dev->next_event, expires))
> > + return 0;
> > +
>
> Hm, given that a good high-res source has nanoseconds resolution,
> what's the chance of this optimization triggering in practice?
> Near zero i think - unless we trigger useless reprogramming without
> having added or removed any new timers - but then we should
> concentrate on analyzing the reason for that redundant reprogramming.
>
> Does it trigger often for you?

The only point where this should trigger is when we come out of C2/C3
and switch the local APIC timer back on. There we reload the
next_event which was discarded in the hardware before we entered C2/C3
and switched to the broadcast timer. So this change would prevent the
rearming of the local APIC after coming out of C2/C3 and probably give
us some new C-State related headaches.

Thanks,

tglx


\
 
 \ /
  Last update: 2009-02-13 10:41    [W:2.079 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site