Messages in this thread | | | Date | Fri, 13 Feb 2009 10:23:57 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: Can request_irq be called under spinlock? |
| |
On Thu, 12 Feb 2009, Jeremy Fitzhardinge wrote: > Thomas Gleixner wrote: > > I dont think that proc_mkdir conventions have changed > > recently. According to git blame fs/proc/generic.c: > > > > ^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 580) ent = > > kmalloc(sizeof(struct proc_dir_entry) + len + 1, GFP_KERNEL); > > > > > > I think its new that request_irq ends up calling proc_mkdir though. But its > moot now anyway; I cleaned up that code, and don't call request_irq under > spinlock any more.
Just checked. The register_irq_proc() and register_handler_proc() calls in request/setup_irq() have the same time stamp in git :)
Thanks,
tglx
| |