Messages in this thread | | | Date | Fri, 13 Feb 2009 09:23:25 +0100 | From | Jiri Slaby <> | Subject | Re: [PATCH 1/1] ipw2200, fix ipw io functions |
| |
On 02/13/2009 01:49 AM, Zhu Yi wrote: > On Fri, 2009-02-13 at 05:29 +0800, Jiri Slaby wrote: >> /* alias to 8-bit direct read (low 4K of SRAM/regs), with debug >> wrapper */ >> -#define ipw_read8(ipw, ofs) __ipw_read8(__FILE__, __LINE__, ipw, ofs) >> +#define ipw_read8(ipw, ofs) ({ \ >> + IPW_DEBUG_IO("%s %d: read_direct8(0x%08X)\n", __FILE__, __LINE__, \ >> + (u32)(ofs)); \ >> + _ipw_read8(ipw, ofs); \ >> +}) > > Please put a do {} while(0) for this and some of below macros as well.
This is impossible, reads need to return a value...
| |