Messages in this thread | | | Date | Fri, 13 Feb 2009 10:52:50 -0800 | From | Jeremy Fitzhardinge <> | Subject | Re: [PATCH] x86 headers: protect page_32.h via __ASSEMBLY__ |
| |
Ingo Molnar wrote: > * Jeremy Fitzhardinge <jeremy@goop.org> wrote: > > >> Ingo Molnar wrote: >> >>> From beb6943d8df7ce9278282101af4e0f6f7b648451 Mon Sep 17 00:00:00 2001 >>> From: Ingo Molnar <mingo@elte.hu> >>> Date: Fri, 13 Feb 2009 13:36:47 +0100 >>> Subject: [PATCH] x86 headers: protect page_32.h via __ASSEMBLY__ >>> >>> >> I think this is wrong in principle. There should never be a reason to >> include a non-_types.h into asm. >> >> (Fine as a build fix, of course.) >> > > Agreed - but it needs fixes to the .S files, these assembly files > include pgtable.h or page.h: >
Piecemeal, or one sweep?
J
| |