Messages in this thread | | | Date | Fri, 13 Feb 2009 19:09:24 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] x86 headers: include linux/types.h |
| |
* Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> Ingo Molnar wrote: >> Regarding the fixlet below - wouldnt PTE_FLAGS_MASK be better placed in >> pgtable_types.h ? It's specifically related to the pte format. OTOH we >> have a lot of PTE details in the page_*types.h files already. >> > > No, you're right. > >> The boundary between page_types.h and pgtable_types.h does not seem to >> be clear to me - what is the principle you followed? >> > > Well, basically anything to do with the internals of a pte*_t go in > pgtable.h. PTE_*_MASK should go there too, and is an oversight (though > its on the margin because of its dependency on the page size/mask > definitions in page*.h).
likewise, PUD_PAGE_* and PAGETABLE_LEVELS should move to pgtable_types.h too i guess. Same goes for *MASK_SHIFT*.
Ingo
| |