lkml.org 
[lkml]   [2009]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86 headers: include linux/types.h

* Jeremy Fitzhardinge <jeremy@goop.org> wrote:

> Ingo Molnar wrote:
>> Regarding the fixlet below - wouldnt PTE_FLAGS_MASK be better placed in
>> pgtable_types.h ? It's specifically related to the pte format. OTOH we
>> have a lot of PTE details in the page_*types.h files already.
>>
>
> No, you're right.
>
>> The boundary between page_types.h and pgtable_types.h does not seem to
>> be clear to me - what is the principle you followed?
>>
>
> Well, basically anything to do with the internals of a pte*_t go in
> pgtable.h. PTE_*_MASK should go there too, and is an oversight (though
> its on the margin because of its dependency on the page size/mask
> definitions in page*.h).

likewise, PUD_PAGE_* and PAGETABLE_LEVELS should move to pgtable_types.h
too i guess. Same goes for *MASK_SHIFT*.

Ingo


\
 
 \ /
  Last update: 2009-02-13 19:11    [W:0.089 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site