Messages in this thread | | | Date | Fri, 13 Feb 2009 08:25:30 -0800 | From | Jeremy Fitzhardinge <> | Subject | Re: [PATCH] x86 headers: include linux/types.h |
| |
Ingo Molnar wrote: > Regarding the fixlet below - wouldnt PTE_FLAGS_MASK be better placed in > pgtable_types.h ? It's specifically related to the pte format. OTOH we > have a lot of PTE details in the page_*types.h files already. >
No, you're right.
> The boundary between page_types.h and pgtable_types.h does not seem to > be clear to me - what is the principle you followed? >
Well, basically anything to do with the internals of a pte*_t go in pgtable.h. PTE_*_MASK should go there too, and is an oversight (though its on the margin because of its dependency on the page size/mask definitions in page*.h).
J
| |