lkml.org 
[lkml]   [2009]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 33/41] asus-laptop: Fix the led behavior with value > 1

> > > From: Corentin Chary <corentincj@iksaif.net>
> > >
> > > commit e3deda9c87ac5eef2b5d18cd0b5511370979ca26 upstream.
> > >
> > > Fix http://bugzilla.kernel.org/show_bug.cgi?id=11613 .
> > >
> > > Signed-off-by: Corentin Chary <corentincj@iksaif.net>
> > > Signed-off-by: Len Brown <len.brown@intel.com>
> > > Cc: Thomas Renninger <trenn@suse.de>
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> > >
> > > ---
> > > drivers/misc/asus-laptop.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > --- a/drivers/misc/asus-laptop.c
> > > +++ b/drivers/misc/asus-laptop.c
> > > @@ -351,7 +351,7 @@ static void write_status(acpi_handle han
> > > static void object##_led_set(struct led_classdev *led_cdev, \
> > > enum led_brightness value) \
> > > { \
> > > - object##_led_wk = value; \
> > > + object##_led_wk = (value > 0) ? 1 : 0; \
> >
> > "= !!value" is standard way to do that.... for unsigned value.
>
> No dispute here, but that's what is upstream :)

No dispute there, I just hope original author fixes it in the upstream
on one sunny day :).

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2009-02-12 10:01    [W:0.164 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site