lkml.org 
[lkml]   [2009]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 9/9] staging/sxg: fix napi interface build
From
From: Greg KH <gregkh@suse.de>
Date: Thu, 12 Feb 2009 15:08:46 -0800

> On Thu, Feb 12, 2009 at 02:56:20PM -0800, David Miller wrote:
> > From: Greg KH <greg@kroah.com>
> > Date: Thu, 12 Feb 2009 11:51:33 -0800
> >
> > > On Wed, Feb 11, 2009 at 01:22:56PM -0800, Randy Dunlap wrote:
> > > > From: Randy Dunlap <randy.dunlap@oracle.com>
> > > >
> > > > Fix staging/sxg napi interface calls:
> > > >
> > > > drivers/staging/sxg/sxg.c:1271: error: implicit declaration of function 'netif_rx_schedule_prep'
> > > > linux-next-20090209/drivers/staging/sxg/sxg.c:1272: error: implicit declaration of function '__netif_rx_schedule'
> > > > drivers/staging/sxg/sxg.c:1325: error: implicit declaration of function 'netif_rx_complete'
> > >
> > > As I count over 80 instances of netif_rx_complete in Linus's tree right
> > > now, I'm guesing this is due to a change from the netdev tree. Which is
> > > fine, but I'll wait until that gets merged with Linus to apply this
> > > patch.
> >
> > Well it means that it won't build in -next until the next merge
> > window.
>
> I can live with that :)
>
> Or is the new api already there and it's safe to make this change now?

If you make the change, your driver will build in Linus's
tree. Just sed 's/netif_rx_/napi_/' for the lines the
above warning triggers on.


\
 
 \ /
  Last update: 2009-02-13 00:25    [W:0.050 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site