Messages in this thread | | | From | David Brownell <> | Subject | Re: [PATCH] usb: musb: - kill the compile warning | Date | Thu, 12 Feb 2009 12:30:06 -0800 |
| |
On Thursday 12 February 2009, Felipe Balbi wrote: > On Thu, Feb 12, 2009 at 07:03:25AM +0100, David Brownell wrote: > > On Friday 06 February 2009, Bryan Wu wrote: > > > - return (MUSB_BUSCTL_OFFSET(i, 0) + mbase); > > > + return (void __iomem *)(MUSB_BUSCTL_OFFSET(i, 0) + mbase); > > > > Why is MUSB_BUSCTL_OFFSET() returning something other than > > an integer? "mbase" is already "void __iomem *", so the only > > way that should trigger a warning is if that OFFSET() macro > > is doing something odd. > > The warning only comes on Blackfin's version of this, this hunk is > unnecessary
We want to get rid of Blackfin-specific warnings too ... but what I was hinting is that this can't be the right fix.
| |