lkml.org 
[lkml]   [2009]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCHv2 5/5] VFS: DazukoFS, stackable-fs, file access control
From
Date
John Ogness <dazukocode@ogness.net> writes:

> Patch 5: Creates /dev/dazukofs.ign as an (optional) mechanism for any
> processes to hide themselves from DazukoFS file access
> control.

Your reference counting is broken. What happens if a process exits
and you are ignoring it.

When fixing this use a struct pid * not struct task_struct *. That
is what struct pid is for there is no need to pin the entire task
struct into memory after the process exits just because
you decided to ignore it.

Eric


\
 
 \ /
  Last update: 2009-02-12 21:27    [W:1.027 / U:1.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site