Messages in this thread | | | Date | Wed, 11 Feb 2009 14:24:09 -0800 | From | Andrew Morton <> | Subject | Re: [Linux-fbdev-devel] [PATCH] fb: hide cursor in graphics mode |
| |
On Tue, 10 Feb 2009 23:50:08 +0200 Risto Suominen <risto.suominen@gmail.com> wrote:
> The same as attachment, so the last line won't disappear. > > Risto > > > [fbcon-graphics-nocursor.diff application/octet-stream (814B)]
help. My knowledge of fbcon is near zero.
> Xserver Xfbdev (kdrive) uses linux framebuffer in graphics mode. It doesn't > need the text mode cursor, it's a bit annoying to have it there sitting in a > corner. This patch disables the cursor even when in graphics mode. > > Signed-off-by: Risto Suominen <Risto.Suominen@gmail.com> > --- > The testing is done on kernel version 2.6.18.
That's a truly ancient kernel. Is the patch needed on current kernels? Does it work correctly in current kernels?
> --- a/drivers/video/console/fbcon.c.org 2007-03-03 07:14:54.000000000 +0200 > +++ b/drivers/video/console/fbcon.c 2009-01-23 12:42:14.000000000 +0200 > @@ -1363,6 +1363,12 @@ static void fbcon_cursor(struct vc_data > int y; > int c = scr_readw((u16 *) vc->vc_pos); > > + if (mode == CM_ERASE && info->fbops->fb_cursor) { > + /* Hide H/W-cursor unconditionally */ > + ops->cursor(vc, info, mode, 0, 0, 0); > + return; > + } > + > if (fbcon_is_inactive(vc, info) || vc->vc_deccm != 1) > return; >
How does the cursor get re-enabled?
Should we be calling ops->cursor() if fbcon_is_inactive() is true?
| |