Messages in this thread | | | Date | Wed, 11 Feb 2009 08:16:40 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH 0/6] ide: more unifications of ATA and ATAPI support |
| |
On Tue, Feb 10, 2009 at 12:19:45AM +0100, Bartlomiej Zolnierkiewicz wrote: > > After this patchset we have a valid struct ide_cmd available also for > ATA_CMD_PACKET commands and comparing struct ide_atapi_pc with ide_cmd it > seems that there are many similarities between them and that we may just > merge both structs (this should also allow us to unify ide-cd code with > non-ide-cd one in ide-atapi.c later). From the quick look the only gotcha > is REQUEST SENSE handling, ->request_sense_pc needs to be converted to > ->request_sense_cmd and we have to be careful with choosing right 'cmd' > in *_issue_pc()... > > Borislav, please take a look and tell me what do you think about it > (also feel free to go ahead with patches :-)...
Yep, like it, especially the idea of a unified ide_cmd thingy and removing the atapi_pc :).
ACK.
-- Regards/Gruss, Boris.
| |