Messages in this thread |  | | From | KOSAKI Motohiro <> | | Subject | Re: [patch] vmscan: rename sc.may_swap to may_unmap | | Date | Tue, 10 Feb 2009 19:00:27 +0900 (JST) |
| |
> On Tue, Feb 10, 2009 at 4:43 AM, Johannes Weiner <hannes@cmpxchg.org> wrote: > > sc.may_swap does not only influence reclaiming of anon pages but pages > > mapped into pagetables in general, which also includes mapped file > > pages. > > > > From shrink_page_list(): > > > > if (!sc->may_swap && page_mapped(page)) > > goto keep_locked; > > > > For anon pages, this makes sense as they are always mapped and > > reclaiming them always requires swapping. > > > > But mapped file pages are skipped here as well and it has nothing to > > do with swapping. > > > > The real effect of the knob is whether mapped pages are unmapped and > > reclaimed or not. Rename it to `may_unmap' to have its name match its > > actual meaning more precisely. > > > > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org> > > --- > > mm/vmscan.c | 20 ++++++++++---------- > > 1 file changed, 10 insertions(+), 10 deletions(-) > > It looks good to me. :) > > Reviewed-by: MinChan Kim <minchan.kim@gmail.com>
me too :)
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
|  |