Messages in this thread Patch in this message | | | Date | Tue, 10 Feb 2009 16:25:40 -0800 | From | Greg KH <> | Subject | [patch 41/56] md: Dont try to set an array to read-auto if it is already in that state. |
| |
2.6.27-stable review patch. If anyone has any objections, please let us know. ------------------
From: NeilBrown <neilb@suse.de>
commit 80268ee9270ebe4847365a7426de91d179e870d0 upstream.
'read-auto' is a variant of 'readonly' which will switch to writable on the first write attempt.
Calling do_md_stop to set the array readonly when it is already readonly returns an error. So make sure not to do that.
Signed-off-by: NeilBrown <neilb@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- drivers/md/md.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -2742,9 +2742,9 @@ array_state_store(mddev_t *mddev, const break; case read_auto: if (mddev->pers) { - if (mddev->ro != 1) + if (mddev->ro == 0) err = do_md_stop(mddev, 1, 0); - else + else if (mddev->ro == 1) err = restart_array(mddev); if (err == 0) { mddev->ro = 2;
| |