Messages in this thread | | | Date | Tue, 10 Feb 2009 22:44:37 +0000 | From | Mel Gorman <> | Subject | Re: [PATCH] hugetlbfs: fix build failure with !CONFIG_HUGETLBFS |
| |
On Tue, Feb 10, 2009 at 11:27:32PM +0100, Stefan Richter wrote: > Fix regression due to 5a6fe125950676015f5108fb71b2a67441755003, > "Do not account for the address space used by hugetlbfs using VM_ACCOUNT" > which added an argument to the function hugetlb_file_setup() but not to > the macro hugetlb_file_setup(). >
/me slaps self
> Reported-by: Chris Clayton <chris2553@googlemail.com> > Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Confirmed that it's a problem and this fixes it. Thanks
Acked-by: Mel Gorman <mel@csn.ul.ie>
> --- > include/linux/hugetlb.h | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index af09660..03be7f2 100644 > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -159,9 +159,9 @@ static inline void set_file_hugepages(struct file *file) > } > #else /* !CONFIG_HUGETLBFS */ > > -#define is_file_hugepages(file) 0 > -#define set_file_hugepages(file) BUG() > -#define hugetlb_file_setup(name,size) ERR_PTR(-ENOSYS) > +#define is_file_hugepages(file) 0 > +#define set_file_hugepages(file) BUG() > +#define hugetlb_file_setup(name,size,acctflag) ERR_PTR(-ENOSYS) > > #endif /* !CONFIG_HUGETLBFS */ > > -- > 1.6.0.6 > > > -- > Stefan Richter > -=====-==--= --=- -=-=- > http://arcgraph.de/sr/ >
-- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab
| |