lkml.org 
[lkml]   [2009]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] write-back: fix break condition
    Andrew Morton wrote:
    >>
    >> - if (nr_to_write > 0)
    >> + if (nr_to_write > 0) {
    >> nr_to_write--;
    >> - else if (wbc->sync_mode == WB_SYNC_NONE) {
    >> - /*
    >> - * We stop writing back only if we are not
    >> - * doing integrity sync. In case of integrity
    >> - * sync we have to keep going because someone
    >> - * may be concurrently dirtying pages, and we
    >> - * might have synced a lot of newly appeared
    >> - * dirty pages, but have not synced all of the
    >> - * old dirty pages.
    >> - */
    >> - done = 1;
    >> - break;
    >> + if (nr_to_write == 0 && wbc->sync_mode == WB_SYNC_NONE) {
    >> + /*
    >> + * We stop writing back only if we are not
    >> + * doing integrity sync. In case of integrity
    >> + * sync we have to keep going because someone
    >> + * may be concurrently dirtying pages, and we
    >> + * might have synced a lot of newly appeared
    >> + * dirty pages, but have not synced all of the
    >> + * old dirty pages.
    >> + */
    >> + done = 1;
    >> + break;
    >> + }
    >> }
    >>
    >> if (wbc->nonblocking && bdi_write_congested(bdi)) {
    >
    > Artem, Nick, please check?

    I have not tested it, but it looks OK to me.

    --
    Best Regards,
    Artem Bityutskiy (Артём Битюцкий)
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-02-10 08:51    [W:0.027 / U:59.264 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site