lkml.org 
[lkml]   [2009]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [linux-pm] [PATCH 3/3] PCI PM: Make warning in pci_legacy_suspend more useful
From
Date
Hi again.

On Sun, 2009-02-01 at 22:34 +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> The warning in pci_legacy_suspend() would be much more useful if it
> printed the name of the function that did the wrong thing. Make it
> do so.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> ---
> drivers/pci/pci-driver.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> Index: linux-2.6/drivers/pci/pci-driver.c
> ===================================================================
> --- linux-2.6.orig/drivers/pci/pci-driver.c
> +++ linux-2.6/drivers/pci/pci-driver.c
> @@ -365,7 +365,9 @@ static int pci_legacy_suspend(struct dev
> if (pci_dev->state_saved)
> goto Fixup;
>
> - if (WARN_ON_ONCE(pci_dev->current_state != PCI_D0))
> + if (WARN_ONCE(pci_dev->current_state != PCI_D0,
> + "PCI PM: Device state not saved by %pF\n",
> + drv->suspend))
> goto Fixup;
> }

Am I right in thinking that WARN_ONCE will only warn about the first
driver that has the problem? If so, wouldn't it be better to make it
warn about all drivers that have the problem, but only once per device?

Regards,

Nigel



\
 
 \ /
  Last update: 2009-02-02 03:11    [W:0.108 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site