lkml.org 
[lkml]   [2009]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/6] x86, 32-bit: Add new pt_regs stubs
On 12/09/2009 04:01 PM, Brian Gerst wrote:
> Add new stubs which add the pt_regs pointer as the last arg, matching
> 64-bit. This will allow these syscalls to be easily merged.
>
> Signed-off-by: Brian Gerst <brgerst@gmail.com>
> +ptregs_##name: \
> + leal 4(%esp),%edx; \
> + movl PT_EBX(%edx),%eax; \
> + jmp sys_##name;

You're introducing a completely unnecessary pipeline serialization here.
Instead do:

movl (PT_EBX+4)(%esp),%eax;

... making the statements independent and therefore executable in parallel.

-hpa


\
 
 \ /
  Last update: 2009-12-10 01:11    [W:0.088 / U:10.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site