[lkml]   [2009]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] [23/31] HWPOISON: add memory cgroup filter
    On Wed, 9 Dec 2009 12:47:27 -0800
    Paul Menage <> wrote:

    > On Tue, Dec 8, 2009 at 1:16 PM, Andi Kleen <> wrote:
    > >
    > > The hwpoison test suite need to inject hwpoison to a collection of
    > > selected task pages, and must not touch pages not owned by them and
    > > thus kill important system processes such as init. (But it's OK to
    > > mis-hwpoison free/unowned pages as well as shared clean pages.
    > > Mis-hwpoison of shared dirty pages will kill all tasks, so the test
    > > suite will target all or non of such tasks in the first place.)
    > While the functionality sounds useful, the interface (passing an inode
    > number) feels a bit ugly to me. Also, if that group is deleted and a
    > new cgroup created, you could end up reusing the inode number.
    I agree.

    > How about an approach where you write either the cgroup path (relative
    > to the memcg mount) or an fd open on the desired cgroup? Then you
    > could store a (counted) css reference rather than an inode number,
    > which would make the filter function cleaner too, since it would just
    > need to compare css objects.
    Sounds reasonable.


     \ /
      Last update: 2009-12-10 01:03    [W:0.023 / U:103.812 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site