lkml.org 
[lkml]   [2009]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/7] mtrr: Remove use_intel()
On 12/09/2009 10:32 AM, Yinghai Lu wrote:
> /*
> * Generic structure...
> */
> struct mtrr_ops generic_mtrr_ops = {
> .use_intel_if = 1,
> .set_all = generic_set_all,
>
> so all cpus that cpuid tell us that there is mtrr support, will all
> have use_intel() == 1

Yes, because the right thing to check isn't the CPU vendor bit but the
CPU feature bits -- all CPUs that have the MTRR feature bit are using
the "Intel interface" -- regardless of if they are made by Intel, AMD,
VIA, or Transmeta. The older AMD, Cyrix etc. interfaces use different bits.

-hpa



\
 
 \ /
  Last update: 2009-12-09 20:07    [W:0.085 / U:1.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site